Fix bad conditional in key loader causing the wrong key to be loaded #2368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwalch
approved these changes
Sep 25, 2019
|
@itsjamie merging without adding to release notes as this appears to be a fix to a regression introduced with some of the type changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Revert the conditional which decides whether to return the cached key to it's pre-TS state. The current logic causes the cached key to be returned for segments of different levels, which causes AES decryption to fail.
Why is this Pull Request needed?
So that AES decryption works
Are there any points in the code the reviewer needs to double check?
No